WIP Definition export: include virtual host metadata#10539
Closed
michaelklishin wants to merge 1 commit intomainfrom
Closed
WIP Definition export: include virtual host metadata#10539michaelklishin wants to merge 1 commit intomainfrom
michaelklishin wants to merge 1 commit intomainfrom
Conversation
lukebakken
approved these changes
Feb 12, 2024
Collaborator
lukebakken
left a comment
lukebakken
left a comment
There was a problem hiding this comment.
The patch works great 👍
michaelklishin
force-pushed
the
rabbitmq-server-10515
branch
from
1f7c6a0 to
2ca0648
Compare
Collaborator
Author
|
Test suite failures need investigating. |
when exporting over the HTTP API. CLI tools use rabbit_definitions:all_definitions/0 which already include the metadata. Closes #10515
michaelklishin
force-pushed
the
rabbitmq-server-10515
branch
from
2ca0648 to
64227ba
Compare
michaelklishin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when exporting over the HTTP API. CLI tools
use
rabbit_definitions:all_definitions/0whichalready include the metadata.
Closes #10515